Repository navigation
Mr Folio no longer has a /redeem command - #255
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Removes Mr Folio's
/redeem. It turned a supporter code into a Discord supporter role, handing out Coffee, Backer or Builder. Ko-fi's own Discord bot manages those roles (and Supporter), so two systems were handing out the same roles, and the bot's daily sweep could take a role from someone who still held it through Ko-fi. McCal chose to remove the command rather than give it a role of its own./redeemis already unregistered from the server (done through the API on 2 Oct); this removes the code behind it.redeem.mjsand its tests, the command's definition and the private-answer plumbing, the daily sweep (scheduled), the D1 binding, and the settings only it used (SUPPORTER_KEYS,WITHDRAWN,ROLE_COFFEE,ROLE_BACKER,ROLE_BUILDER, the cron).discord.mjs.wrangler.tomlnow has justGUILD_IDandROLE_UPDATES.tools/folio-bot/README.mdsays there is no/redeemand why;schema.sqlmarksdiscord_rolesas unused. The table is kept, not dropped.How I checked it
node --testintools/folio-bot: 36 pass (50 before; the 14 that went are/redeem's).tools/kofi-worker: 36 pass.wrangler deploy --dry-run: 16 KiB, with onlyGUILD_IDandROLE_UPDATESas variables, no database and no cron.tools/folio-bot,~/dev/folio-site/node_modules/.bin/wrangler deploy) removes the D1 binding and the cron, which is intended.Cheap way out: revert, and re-register the command with
register.mjs.