Repository navigation
The site is asked to rebuild on a release, not on every push - #253
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
site.yml asked foliolauncher.com to rebuild on every push to main that touched the changelog, roadmap, packages or screen table. The site reads those files at the latest release's tag, not at main, so a push changes nothing until a release is cut. It fired six times on 2 Oct and every rebuild was identical.
What is true now:
Checked: the YAML parses, and its triggers are release (published) and workflow_dispatch. The old push trigger worked end to end 6 times this morning (the logs said "Asked foliolauncher.com to rebuild"), so the sender and token are proven; what this PR cannot show is the new run, because a workflow can only be run by hand once it is on main.
Worth knowing: a release published from Actions with the default token would not trigger this (GitHub does not fire workflows from its own token's events). Folio's releases are published by hand, so it does. Also, a release can fire this before its APK and checksums finish uploading; the site's sync now waits for them (folio-site, separate PR).
Not checked: the release trigger itself, which can only be exercised by the next published release.