The supporter email's button opens a page on the site - #249
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
The supporter email's button was
folio://redeem?c=<code>and did nothing in Gmail on Android (McCal tapped it on a phone, 2 Oct): Gmail won't open a custom-scheme link. It now links tohttps://foliolauncher.com/redeem/#<code>, a page on the site (McCal-Codes/folio-site#19) that shows the code and has an Add to Folio button that opens Folio's own redeem screen on Android, a Copy button, and the paste-it-in instructions. The code sits after the#, so it never reaches a server.tools/kofi-worker/email.jsonly; the worker's other behavior and the pool rules are unchanged.How I checked it
node --testintools/kofi-worker: 36 pass. The link test now checks the https form, that nofolio://link is left in either part, and that the code in the fragment is something the page accepts (letters, digits and hyphens, 20 to 200).https://foliolauncher.com/redeem/#<anything-24-groups-long>shows a code, then merge this and runwrangler deploy(yours to run).Cheap way out: revert;
wrangler rollbackputs the earlier email back.