Fix Oracle queries with trailing semicolons#273
Merged
Conversation
python-oracledb requires SQL text without a trailing statement terminator, while a final semicolon remains part of PL/SQL syntax. Normalize statements at the Oracle adapter boundary so CLI, TUI, worker, and legacy-provider execution share the correction. Constraint: Preserve final semicolons for anonymous PL/SQL blocks and stored program definitions Rejected: Normalize all database statements globally | other drivers accept terminators and Oracle PL/SQL requires them Confidence: high Scope-risk: narrow Directive: Keep Oracle SQL normalization at the adapter boundary and preserve PL/SQL syntax Tested: 23 Oracle provider tests; 1045 unit tests; 300 UI tests; focused Ruff and MyPy Not-tested: Live Oracle server; no Oracle container is running locally Related: #260
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
Fixes #260