Keep PostgreSQL BC dates queryable#271
Merged
Merged
Conversation
PostgreSQL can return temporal values outside Python's representable year range. Register connection-local psycopg2 casters that preserve normal date and datetime objects while falling back to raw text for unsupported values and arrays. Constraint: Python datetime cannot represent BC years Rejected: Rewrite user queries with explicit text casts | unsafe for arbitrary SQL and changes query semantics Confidence: high Scope-risk: narrow Directive: Preserve psycopg2 native temporal objects whenever Python can represent the value Tested: 8 live PostgreSQL regressions; 28 existing PostgreSQL integrations; 1039 unit tests; targeted Ruff Not-tested: CockroachDB-specific temporal decoding Related: #263
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Fixes #263