Ignore trailing comments in process worker validation#269
Merged
Conversation
The process worker counted raw SQL fragments before removing comment-only fragments, so a comment after a semicolon was rejected as a second statement. Reuse the existing comment classifier when enforcing the worker's single-statement boundary. Constraint: Process workers must continue rejecting multiple executable statements Rejected: Change SQL splitting semantics | broader behavior change than the worker validation bug requires Confidence: high Scope-risk: narrow Directive: Keep worker statement validation aligned with other executable-statement paths Tested: 48 focused process-worker and multi-statement tests; Ruff; mypy Not-tested: Standalone trailing block comments Related: #254
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #254.
Ignores comment-only fragments during process-worker statement validation, with regression coverage.