fix: say when slint init writes a config that shadows an inherited one - #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
slint initin a subdirectory checked only./slint.toml, so it happily wrote a config that shadows an inherited parent config for everything linted below — with no sign.initnow runs the same walk-up lookup the linter uses at run time; when a config already governs the directory, it names that file and says writing here will shadow it. The file is still written (init's job is to write); the warning is the news.Path::new(".").parent()is the empty path, which makes the relative walk stop one level short.Fixes #40
Test plan
./scripts/check.sh --no-js)