fix: add skip-to-content link as the first focusable element - #353
Open
MaximeGaudin wants to merge 1 commit into
Open
fix: add skip-to-content link as the first focusable element#353MaximeGaudin wants to merge 1 commit into
MaximeGaudin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Page.astro's shared layout renders a sticky header (logo + 6 nav links) before<main>, with no bypass link — keyboard and screen-reader users had to tab through the whole nav on every page to reach content.<body>, targeting<main id="main">(id added to the existing<main>).--signal-brightfocus outline. It sits above the sticky header (z-index: 100> header's40).Implements WCAG 2.4.1 Bypass Blocks (technique G1).
Fixes #142
Test plan
<a class="skip-link" href="#main">is the first child of<body>on every page (index, rules, …) and that<main id="main">is the matching target.--paper-raisedon--ink) is 18:1, well above AA.pnpm run buildin apps/docs: 48 pages built.pnpm run lint(biome + astro check + check-no-todos): 0 errors, 0 warnings, clean.