fix: darken --text-muted to meet WCAG AA contrast on light backgrounds - #352
Open
MaximeGaudin wants to merge 1 commit into
Open
fix: darken --text-muted to meet WCAG AA contrast on light backgrounds#352MaximeGaudin wants to merge 1 commit into
MaximeGaudin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--text-muted(#6b7f8e) is used for small body text (10–13.5px:.rule-summary,.badge.plain,.back-link,.citation span, tableth) on the light paper backgrounds. Measured via the WCAG relative-luminance formula, its worst case is 3.51:1 (on the body gradient's darkest stop#e4edf3) and 3.75:1 on--paper— below the 4.5:1 AA minimum for normal text.--text-mutedto#576874, which clears 4.5:1 on every light background it sits on: 4.87:1 on#e4edf3, 5.20:1 on--paper, 5.51:1 on--paper-raised.Not changed (verified already passing)
#7f93a1at.console-bar(line 522) andfooter p(line 902) as 2.87:1. That computation compared them against--paper, but both actually sit on dark panes:.consolebackground#060c11andfooterbackground#071016. On their real backgrounds the contrast is 6.17:1 and 6.02:1 — comfortably above AA. No change needed.--signal-bright(#14c4b5) is left as-is: the issue explicitly does not assert it as a failure (its traced usages sit on dark console/hero panels) and flags it only as a devtools follow-up.Fixes #120
Test plan
--text-mutedagainst every light background in the palette (#e4edf3,#eef4f7,#f7fafc); the new value is >= 4.5:1 in all cases, and the#7f93a1/--text-secondarypairs were re-verified as passing.pnpm run buildin apps/docs: 48 pages built.pnpm run lint(biome + astro check + check-no-todos): 0 errors, 0 warnings, clean.