fix: verify release tarball checksum before sudo install in README - #349
Merged
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sudo tar xz -C /usr/local/bin, so a compromised release/CDN/MITM would write into a root-owned directory undetected.<artifact>.sha256asset that release: no checksums published as downloadable release assets #201 (PR fix: publish a sha256 checksum file for every release asset #336) publishes next to it, verify withshasum -a 256 -c(macOS) /sha256sum -c(Linux), and only extract as root if the checksum matches.Depends on #336 (publish
<artifact>.sha256release assets) — the verification steps reference those assets.Fixes #180
Test plan
<file>.sha256with the exact command the release workflow uses (sha256sum file > file.sha256) and confirmed bothshasum -a 256 -candsha256sum -creport OK against it.