fix: publish GitHub releases as drafts for maintainer review - #348
Open
MaximeGaudin wants to merge 1 commit into
Open
fix: publish GitHub releases as drafts for maintainer review#348MaximeGaudin wants to merge 1 commit into
MaximeGaudin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gh release create/gh release editran without--draft, so the release and all binaries were publicly visible the moment the workflow finished, with no review gate.--draft: a first run creates a draft, and a re-run against an existing tag re-drafts it so the updated notes/binaries get reviewed again. A maintainer publishes explicitly withgh release edit <tag> --draft=false(or from the GitHub UI).Note: the Homebrew tap formula is updated in the same run and points at the release download URLs, which only resolve publicly once the release is published —
brew installbecomes available at that point, as intended by the review gate.Fixes #220
Test plan
release.ymlparses as valid YAML;gh release create --help/gh release edit --helpconfirm--draftsupport on both commands, andgh release uploadworks against draft releases.workflow_dispatch-only, so it is not exercised by this PR's CI.