fix: generate and publish THIRD-PARTY-NOTICES for bundled dependencies - #346
Open
MaximeGaudin wants to merge 1 commit into
Open
fix: generate and publish THIRD-PARTY-NOTICES for bundled dependencies#346MaximeGaudin wants to merge 1 commit into
MaximeGaudin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/generate-third-party-notices.mjs, which readscargo metadataand generatesTHIRD-PARTY-NOTICES.md: every dependency with its version and SPDX expression, the distinct license texts deduplicated into an appendix (read from the local cargo registry cache), and a fallback section with repository links for the 37 crates that ship no license file in the published package. The generated file is committed (441 crates, 99 distinct texts).THIRD-PARTY-NOTICES.mdinto the artifacts, so it is published as a downloadable release asset alongside the binaries. It is published as a separate asset rather than inside the binary tarballs on purpose: the tarball layout is consumed as-is by the documented install command (sudo tar xz -C /usr/local/bin), the Homebrew formula, and the binstall metadata, and adding a second file would break all three.Fixes #212
Test plan
node scripts/generate-third-party-notices.mjsruns clean and is idempotent; the todo-marker check passes on the script.release.ymlparses as valid YAML (release workflow isworkflow_dispatch-only, so the copy step is not exercised by this PR's CI).