fix: make the rust-toolchain.toml comment match what it actually does - #345
Open
MaximeGaudin wants to merge 1 commit into
Open
fix: make the rust-toolchain.toml comment match what it actually does#345MaximeGaudin wants to merge 1 commit into
MaximeGaudin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
channel = "stable"is a floating channel, not a pin.stablechannel (unpinned, resolved per machine) with rustfmt and clippy.The issue offered "pin to a real version or correct the comment". Pinning to a specific version is a toolchain-policy decision (which version, and how it interacts with CI — see below) that I left to the maintainer; this PR does the unambiguous half.
Finding worth a follow-up: the file currently overrides CI's toolchain selection
Verified locally with rustup: the toolchain file takes precedence over
rustup default(rustup precedence:RUSTUP_TOOLCHAIN> directory override > toolchain file > default). Thedtolnay/rust-toolchainaction installs its@revtoolchain and sets it withrustup default— which this file then overrides, becausechannel = "stable"resolves to the current stable. Consequence: in CI, every job — including themsrvjob that intends 1.95.0 — actually runs on whatever stable is current at run time, so the MSRV floor is not being tested. (Repro: in a dir with this file present,rustup default 1.95.0+rustc --versionreports "overridden by rust-toolchain.toml" and uses stable.)If the maintainer wants, the clean follow-up is to drop the
channelline (leavingcomponents/profile), which lets each CI job's@revtake effect as intended — at the cost of local developers using their own default toolchain instead of a forced stable.Fixes #223
Test plan