fix: fail on transitive unmaintained crates unless explicitly ignored - #342
Open
MaximeGaudin wants to merge 1 commit into
Open
fix: fail on transitive unmaintained crates unless explicitly ignored#342MaximeGaudin wants to merge 1 commit into
MaximeGaudin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unmaintained = "workspace"made transitive unmaintained crates pass as notes, so an archived crate sneaking into the tree via a dependency was never flagged.unmaintained = "all"and moved the four currently-transitive unmaintained crates into explicit, reasoned, expiry-datedignoreentries:bitmaps/im-rc/sized-chunks(via wasm-compose → wasmtime 43, pinned by extism 1.30) andpaste(proc-macro dep of genai 0.6.5). All four are archived upstream with no alternative on our dependency path today.cargo deny checkuntil it is explicitly ignored with a reason and an expiry date.Fixes #219
Test plan
cargo deny check advisoriespasses with the new config.im-rcignore entry makes the check fail witherror[unmaintained]: im-rc is unmaintained— the strictness is real, then restored.