fix: fail CI when rules.json drifts from the CLI catalogue - #339
Open
MaximeGaudin wants to merge 1 commit into
Open
fix: fail CI when rules.json drifts from the CLI catalogue#339MaximeGaudin wants to merge 1 commit into
MaximeGaudin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apps/docs/src/data/rules.jsonis hand-synced from the CLI viapnpm sync:docs, and nothing in CI verified it stayed in sync — a rule edit without a re-sync would publish wrong docs.rules-syncCI job: builds the CLI, runsslint rules --json, and diffs the output against the committedrules.json, failing with a pointer topnpm sync:docson drift.Verified both directions locally: the CLI's
--jsonoutput is currently byte-identical to the committed file (the job passes), and a one-character edit torules.jsonis caught by the diff (the job fails with the sync hint).Fixes #186
Test plan
cargo run -q -p slint-cli -- rules --jsonoutput diffs clean against the committed file.