fix: add cargo-binstall metadata for the prebuilt release assets - #337
Open
MaximeGaudin wants to merge 1 commit into
Open
fix: add cargo-binstall metadata for the prebuilt release assets#337MaximeGaudin wants to merge 1 commit into
MaximeGaudin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
slint-cliships prebuilt binaries in GitHub Releases but itsCargo.tomlcarried no[package.metadata.binstall]section, socargo binstallhad no way to find the assets and would fall back to compiling from source.pkg-urloverride for each of the five published targets, pointing at the exact release asset name (slint-darwin-arm64.tar.gz,slint-linux-amd64.tar.gz,slint-windows-amd64.zip, ...). The templates use the{ repo }and{ version }keys and match the repo's tag scheme (tag equals the crate version, verified against the existing v0.2.0 release assets).pkg-fmtistgzexceptzipfor the Windows override..sha256files published alongside the assets) is handled separately in the companion PR for release: no checksums published as downloadable release assets #201.Verified:
cargo metadataparses the manifest and exposes the binstall metadata.Fixes #146
Test plan
cargo metadata --no-depsparses the updated manifest (metadata present).