Skip to content

fix: fail the release run when the tag does not match the workspace version - #335

Open
MaximeGaudin wants to merge 1 commit into
mainfrom
fix/issue-197-tag-version-check
Open

fix: fail the release run when the tag does not match the workspace version#335
MaximeGaudin wants to merge 1 commit into
mainfrom
fix/issue-197-tag-version-check

Conversation

@MaximeGaudin

Copy link
Copy Markdown
Owner

Summary

  • release.yml built and published whatever tag it was pointed at without ever checking it against the crate version, so a mistyped or stale tag would ship a release whose assets do not match Cargo.toml.
  • Added a verify-tag job (checkout the tag, compare ${TAG#v} to the [workspace.package] version in the root Cargo.toml, fail with an explicit error otherwise) and made build depend on it, so a mismatch fails before any build matrix leg starts.

Both the matching and mismatching cases were exercised locally against the real Cargo.toml.

Fixes #197

Test plan

  • Workflow file parses as valid YAML; comparison logic verified locally for both outcomes (CI-only change, no code touched).
  • CI green on the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

release.yml never verifies the release tag matches the Cargo.toml workspace version

1 participant