fix: fail the release run when the tag does not match the workspace version - #335
Open
MaximeGaudin wants to merge 1 commit into
Open
fix: fail the release run when the tag does not match the workspace version#335MaximeGaudin wants to merge 1 commit into
MaximeGaudin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release.ymlbuilt and published whatever tag it was pointed at without ever checking it against the crate version, so a mistyped or stale tag would ship a release whose assets do not matchCargo.toml.verify-tagjob (checkout the tag, compare${TAG#v}to the[workspace.package] versionin the rootCargo.toml, fail with an explicit error otherwise) and madebuilddepend on it, so a mismatch fails before any build matrix leg starts.Both the matching and mismatching cases were exercised locally against the real
Cargo.toml.Fixes #197
Test plan