fix: run Clippy and the TODO check on the Windows leg too - #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
checkjob's Clippy step was guarded withif: matrix.os != 'windows-latest'and the TODO/stub check withif: runner.os != 'Windows', so the Windows matrix leg only ever rancargo test— an unexplained coverage gap.scripts/check-no-todos.mjsrun on all three OSes.Why this is safe: the Windows leg already compiles the entire workspace (including the C build in
aws-lc-sys) viacargo test --workspace, and the release workflow builds the Windows target the same way, so the only new work is the clippy lint pass over code that is already type-checked on Windows. The todo checker is a plain Node script with no POSIX-only APIs (CRLF is handled by its line splitting). No#[cfg(windows)]code exists in the workspace, so no platform-specific lint surface is introduced.Fixes #184
Test plan
checkleg now executes both steps).