Skip to content

refactor(config): split HandleWebMessage into one handler per bridge message #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Maxaubert merged 11 commits into from
Oct 14, 2026
Merged

refactor(config): split HandleWebMessage into one handler per bridge message #479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7a1145e
refactor(config): move the ready handler out of HandleWebMessage (#474)
Maxaubert Oct 13, 2026
b096fa7
refactor(config): move the setConfig/setConfigPersist handler out of …
Maxaubert Oct 13, 2026
e53272d
refactor(config): move the saveSession handler out of HandleWebMessag…
Maxaubert Oct 13, 2026
ea10560
refactor(config): move the discardSession handler out of HandleWebMes…
Maxaubert Oct 13, 2026
2360d2a
refactor(config): move the window handler out of HandleWebMessage (#474)
Maxaubert Oct 13, 2026
22eb9aa
refactor(config): move the pickExe handler out of HandleWebMessage (#…
Maxaubert Oct 13, 2026
43e1de5
refactor(config): move the openIni handler out of HandleWebMessage (#…
Maxaubert Oct 13, 2026
c264362
refactor(config): move the exportDiagnostics handler out of HandleWeb…
Maxaubert Oct 13, 2026
e7abd4f
refactor(config): move the createProfile handler out of HandleWebMess…
Maxaubert Oct 13, 2026
7a584d6
refactor(config): move the deleteProfile handler out of HandleWebMess…
Maxaubert Oct 13, 2026
d704938
docs(config): point at the split bridge handlers (#474)
Maxaubert Oct 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/architecture/09-settings-ui.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ onboarded.
## The bridge

The page posts JSON with `window.chrome.webview.postMessage`; `HandleWebMessage` is the
authoritative message list, and `ui/src/bridge.js` mirrors it (request/reply pairs become
authoritative message list (its dispatch chain in `src/config_ui/main.cpp`; each longer message has
its own `On<Message>` handler just above it), and `ui/src/bridge.js` mirrors it (request/reply pairs become
promises). The host's JSON helpers live in the pure `src/config_ui/bridge_json.h`
(`tests/test_bridge_json.cpp`): `JsonField` reads one top-level string field and nothing else (the
page stringifies every value), and `JsonEscape` covers every control character: one unescaped
Expand Down
Loading
Loading