Repository navigation
feat(tools): store selector candidates for browser clicks - #1
Merged
Merged
Conversation
Snapshot refs and click results previously kept a single CSS path per element, leaving replay nothing to fall back on when the DOM shifts. Each snapshot ref now also records an xpath and test-id selector, and the click action returns the resolved candidate set in its details so downstream traces have alternatives to retry with. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
browsertool,action: "snapshot") now also record anxpathand atestIdselector per element, alongside the existingselectorCSS path.resolveLocatorsurfaces the candidate set, andaction: "click"returns it in the tool resultdetails(action,targetId,target,selectors) so session traces store every way to re-find the clicked element instead of just the one selector that was used.Upstream PR: understudy-ai#26
Test plan
pnpm build— all packages compilepnpm typecheck(packages/tools) — cleanpnpm lint(changed files) — cleanvitest packages/tools/src/__tests__/browser-tool.test.ts— 11/11 passbrowsertoolsnapshot→clickon a real page, inspectdetails.selectorsGenerated with Devin