Skip to content

Tests: use invented fixture names - #41

Merged
danbarker merged 1 commit into
mainfrom
generic-fixtures-and-wording
Nov 14, 2026
Merged

danbarker merged 1 commit into
mainfrom
generic-fixtures-and-wording

Conversation

@danbarker

@danbarker danbarker commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Test fixtures use acme-app style folder names consistently, with the typed prefixes in the composer tests changed to match. No product code changes.

Ran RecentStartFoldersTest, ComposerViewModelTest and JournalSyncEngineTest locally: all pass.
🤖 Generated with Claude Code


Note

Low Risk
Test-only string renames with no production code touched.

Overview
Test data only: folder/session titles and related partial prefixes are renamed from yearly-* to acme-* in three test files.

JournalSyncEngineTest uses acme-app as the plain session title in the status-first auto-open case. ComposerViewModelTest updates /start inputs, recent-folder records, suggestions, and palette folder picks (e.g. ~/a → ~/acme-app, ~/acme-api, ~/acme-app-v2). RecentStartFoldersTest aligns the record/match fixture with ~/acme-app and prefix ~/a.

No production source changes; behavior under test is unchanged aside from fixture naming.

Reviewed by Cursor Bugbot for commit 30560f4. Bugbot is set up for automated code reviews on this repo. Configure here.

Summary by CodeRabbit

  • Tests
    • Updated test examples to use acme-app and acme-api paths.
    • Existing checks for conversation auto-opening, folder completion, suppression, and recent-folder matching remain covered.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 14, 2026

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The test fixtures replace yearly-app titles and paths with acme-app examples. Existing expected outcomes and assertions remain unchanged.

Changes: Test fixture updates

Layer / File(s) Summary
Update test fixture examples
app/src/test/java/chat/matron/android/viewmodels/ComposerViewModelTest.kt, app/src/test/java/chat/matron/android/viewmodels/RecentStartFoldersTest.kt, app/src/test/java/chat/matron/android/journal/JournalSyncEngineTest.kt
Folder completion and recent-folder tests use acme-app paths and prefixes. The journal sync test uses the acme-app title. The existing assertions remain unchanged.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: Minimal · up to 30560

This PR changes only test fixture names, with no product code changes. The author reports the affected tests pass, and no merge-blocking risk is evident.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "Tests: use invented fixture names" matches the changeset. The PR replaces test fixtures such as yearly-app and yearly-api with acme-app and acme-api in three test files. The title names the…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "Tests: use invented fixture names" matches the changeset. The PR replaces test fixtures such as yearly-app and yearly-api with acme-app and acme-api in three test files. The title names the main change in clear, specific terms, and the commit message matches it. The changes touch tests only, and the title says so.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 1b1eb92 and 30560f4.

Files selected for processing: 3

  • app/src/test/java/chat/matron/android/journal/JournalSyncEngineTest.kt
  • app/src/test/java/chat/matron/android/viewmodels/ComposerViewModelTest.kt
  • app/src/test/java/chat/matron/android/viewmodels/RecentStartFoldersTest.kt

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@danbarker
danbarker merged commit 3cadc61 into main Nov 14, 2026
9 checks passed
@danbarker
danbarker deleted the generic-fixtures-and-wording branch November 14, 2026 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant