Repository navigation
Silent events: shown in the chat, never counted as unread - #40
Conversation
An event whose payload carries silent: true (a card that only records something, such as the one for a reminder an agent set itself) no longer adds to a conversation's unread count. The row itself is shown as before. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
The journal protocol gains a payload flag,
silent: true, for content the user can read but is never told about. A bridge sets it on the Send now / Cancel card it posts when an agent sets itself a reminder.The app counts unread on the device, so it has to apply the rule too. A silent event no longer adds to a conversation's unread count, live or when a read marker or a history page recounts it. The row is still shown in the chat with its buttons, and still appears as the conversation's latest line in the list.
No screen changes: the only visible difference is an unread pill that no longer appears. Covered by a store test.
🤖 Generated with Claude Code
Note
Low Risk
Localized unread-badge logic in the journal store with a dedicated test; no auth, sync wire, or UI surface changes beyond badge counts.
Overview
The journal protocol’s
silent: truepayload flag is now honored when the Android client computes conversation unread badges. Message-type events with a JSONtruesilentfield remain visible in the thread and can still drive the chat-list snippet, but they no longer add tounreadCount.JournalEventType.isSilentcentralizes the rule (only JSON booleantruecounts). LiveapplyJournalskips the incremental unread bump for silent traffic;read_markerandinsertHistorypaths use a newrecountUnreadhelper that starts fromcountUnreadand subtracts rows flagged silent viaEventDao.unreadMentioningSilent(string prefilter on"silent"in payload, then Kotlin parsing). A store test locks in behavior versus non-silent messages and read-marker recounts.Reviewed by Cursor Bugbot for commit 51ec5e3. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit
trueBoolean value marks an event as silent; other values, and message text that merely mentions “silent,” do not affect unread counts. Normal messages continue to be counted.