Skip to content

Docs and tests: generic wording #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danbarker merged 1 commit into from
Nov 14, 2026
+5 −4
Merged

Docs and tests: generic wording #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/exposure-modes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,5 @@ warns about the unknown certificate on first connection — accept it only if
the fingerprint matches. If the server's IP changes, re-running `setup.rb`
regenerates the certificate (new fingerprint, apps must re-accept).

Trade-off to know: until the Matron apps ship pinned-certificate trust
(SP5), only clients that can accept a self-signed cert can connect.
Trade-off to know: until the Matron apps ship pinned-certificate trust,
only clients that can accept a self-signed cert can connect.
5 changes: 3 additions & 2 deletions test/matron_module_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,9 @@ def test_openai_key_line_is_empty_when_unconfigured
end
end

# Production path: Chef merges the key into /opt/dev-boxer/secrets.yml
# (never config.yml), and Config.load folds secrets.yml over config.yml.
# When a config-management tool supplies the key, it merges it into
# secrets.yml (never config.yml), and Config.load folds secrets.yml over
# config.yml.
def test_openai_key_line_renders_from_secrets_yml
Dir.mktmpdir do |dir|
config_path = File.join(dir, "config.yml")
Expand Down
Loading