Version Packages - #84
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or setup this action to publish automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
fiber@0.14.7
Patch Changes
#83
5f8fde8Thanks @MathiasWP! - Validate request bodies with Ajv, and read credential paths with real JSONPath.Body linting was a hand-written walker over "a deliberately useful subset" of JSON Schema, and the subset was the problem: no
$ref, nominimum,pattern,uniqueItems,minLength,patternProperties,if/thenordependentSchemas. All of those passed silently, so a body could be reported clean and still be rejected by the API that published the schema. Ajv is the reference implementation of what that walker was approximating.What stays hand-written is the part that isn't JSON Schema: OpenAPI 3.0's
nullable, folded into a union type, andtypevalues that don't exist. One real 3.1 document arrives with"type": "undefined"310 times alongsideemoji,icon,voidandhttp— Ajv rejects those at compile time, which would cost that schema all of its linting rather than one field's, so the invented names are dropped and every valid constraint beside them keeps working. Messages are unchanged, including the "must be number, not string" phrasing Ajv leaves out.Credential paths now go through
serde_json_path, so a capture rule can use$..id_tokento find a token whose nesting depth you don't know, or$.keys[?(@.active == true)].secretto pick the entry that is current rather than pinning an index that moves. The dotted form every saved rule already uses keeps working: it isn't valid JSONPath —$.data.tokens.0.valueneeds[0]under RFC 9535 — so the query is tried first and the original walk answers for anything it rejects. A query matching several nodes reports nothing rather than picking arbitrarily.