Preserve whitespace in literal-only number format sections - #362
Merged
MathNya merged 1 commit intoSep 6, 2026
Merged
Conversation
Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
Contributor
Author
|
CI is currently red for failures already present on the base branch, rather than for this two-line change:
The same base-wide failures are visible on the recently merged #361 and on the upstream |
13 tasks
Owner
|
Thank you for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
#361 correctly selects and decodes a placeholder-free zero section, but the early return trims its result. For
#,##0_);[Red]\(#,##0\);\-\ \that changes the requested-display to-, shifting a right-aligned dash by the width of two spaces.Testing
cargo test --lib(119 passed)cargo clippy -- -D warningscargo +nightly fmt --all -- --checkgit diff --checkFollow-up to #361.