sql: Remove enable_multi_replica_sources feature flag#36443
Draft
jubrad wants to merge 1 commit intoMaterializeInc:mainfrom
Draft
sql: Remove enable_multi_replica_sources feature flag#36443jubrad wants to merge 1 commit intoMaterializeInc:mainfrom
jubrad wants to merge 1 commit intoMaterializeInc:mainfrom
Conversation
This flag was already defaulting to `true` and is no longer needed. Removing it entirely eliminates the bug where `ALTER CLUSTER ... SET (SIZE, REPLICATION FACTOR 1) WITH (WAIT FOR ...)` could bypass the single-replica guard when the flag was set to `false`. Fixes SQL-212. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enable_multi_replica_sourcesdyncfg flag entirely, making multi-replica sources always enabled.ALTER CLUSTER ... SET (SIZE, REPLICATION FACTOR 1) WITH (WAIT FOR ...)bypassed the single-replica guard whenenable_multi_replica_sources=false.contains_single_replica_objectsfunction,CreateReplicaFailStorageObjectserror variant, and guard blocks in the sequencer and planner.Fixes SQL-212.
Test plan
managed_cluster.slttests pass (the guards being removed are dead code since the flag defaults totrue)🤖 Generated with Claude Code