fix(adapter): preserve workload_class during zero-downtime cluster alter#36440
Draft
jubrad wants to merge 1 commit intoMaterializeInc:mainfrom
Draft
Conversation
…ter finalization The zero-downtime finalization path for ALTER CLUSTER ... WITH (WAIT FOR / UNTIL READY) was reading workload_class from the catalog (the old value) instead of the planned config, silently dropping any workload_class change included in the ALTER statement. Thread the new workload_class through AlterClusterWaitForHydrated and AlterClusterFinalize so finalize_alter_cluster_stage uses the planned value. Fixes SQL-211. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jubrad
force-pushed
the
justin/sql-211-alter-cluster-set-size-workload-class-with-wait-for-until
branch
from
9e7195c to
d2c1bff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ALTER CLUSTER ... SET (SIZE, WORKLOAD CLASS) WITH (WAIT FOR / UNTIL READY)was silently dropping the workload class change because the zero-downtime finalization code readworkload_classfrom the catalog (old value) instead of the planned config.workload_classthroughAlterClusterWaitForHydratedandAlterClusterFinalizesofinalize_alter_cluster_stageuses the planned value.WAIT FORandWAIT UNTIL READYpaths.Fixes SQL-211.
Test plan
bin/sqllogictest test/sqllogictest/managed_cluster.sltpasses with the new regression test🤖 Generated with Claude Code