Fix session based http auth allowed roles#36306
Merged
alex-hunt-materialize merged 3 commits intoMaterializeInc:mainfrom Apr 29, 2026
Merged
Conversation
alex-hunt-materialize
force-pushed
the
fix_session-based_http_auth_allowed_roles
branch
from
1619201 to
4add71d
Compare
alex-hunt-materialize
force-pushed
the
fix_session-based_http_auth_allowed_roles
branch
from
4add71d to
c9813e6
Compare
alex-hunt-materialize
force-pushed
the
fix_session-based_http_auth_allowed_roles
branch
from
c9813e6 to
efd8f6c
Compare
Contributor
Author
mtabebe
approved these changes
Apr 28, 2026
Contributor
mtabebe
left a comment
mtabebe
left a comment
There was a problem hiding this comment.
LGTM thanks for the test
def-
reviewed
Apr 29, 2026
| agents: | ||
| queue: hetzner-aarch64-4cpu-8gb | ||
|
|
||
| - id: http-auth |
Contributor
There was a problem hiding this comment.
This can probably live in Nightly, I don't expect breaking to be high risk.
Contributor
Author
There was a problem hiding this comment.
moved
alex-hunt-materialize
deleted the
fix_session-based_http_auth_allowed_roles
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes https://github.com/MaterializeInc/database-issues/issues/11340
Description
Fix session based http auth allowed roles.
Prevents obtaining a session token for roles not allowed, and prevents using a previously obtained (not sure how this would be possible) session token for a role that is disallowed.
Verification
New http-auth test.