DRAFT: [SS-66] AWS PRIVATELINKS syntax for Kafka (Confluent Cloud)#35455
Closed
ublubu wants to merge 8 commits intoMaterializeInc:mainfrom
Closed
DRAFT: [SS-66] AWS PRIVATELINKS syntax for Kafka (Confluent Cloud)#35455ublubu wants to merge 8 commits intoMaterializeInc:mainfrom
ublubu wants to merge 8 commits intoMaterializeInc:mainfrom
Conversation
Contributor
|
Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone. PR title guidelines
Pre-merge checklist
|
ublubu
force-pushed
the
privatelink
branch
4 times, most recently
from
71451c6 to
0f1eb7a
Compare
ublubu
force-pushed
the
privatelink
branch
2 times, most recently
from
3f643ef to
9fa6773
Compare
ublubu
force-pushed
the
privatelink
branch
2 times, most recently
from
3830617 to
b62d000
Compare
ublubu
changed the title
6 tasks
jubrad
added a commit
that referenced
this pull request
Apr 27, 2026
## Follow up of #35455 ## Summary - Adds `BOOTSTRAP BROKER 'addr' USING AWS PRIVATELINK conn (...)` — new top-level option that provides the initial bootstrap address with an explicit PrivateLink tunnel, preserving the real hostname for correct TLS SNI - Adds `MATCHING 'pattern' USING AWS PRIVATELINK conn (...)` inside `BROKERS (...)` — pattern-based routing rules for dynamically discovered brokers returned in Kafka metadata - Replaces the `AWS PRIVATELINKS` syntax which used a `TO` keyword inconsistent with the existing `USING AWS PRIVATELINK` syntax and overloaded exact-match patterns as implicit bootstrap addresses - Updates parser, planner, and storage layer to support the new constructs ### Example ```sql CREATE CONNECTION kafka TO KAFKA ( BROKERS ( 'lkc-825730.endpoint.cloud:9092' USING AWS PRIVATELINK pl_conn, MATCHING '*use1-az1*' USING AWS PRIVATELINK pl_conn (AVAILABILITY ZONE 'use1-az1'), MATCHING '*use1-az4*' USING AWS PRIVATELINK pl_conn (AVAILABILITY ZONE 'use1-az4'), MATCHING '*use1-az6*' USING AWS PRIVATELINK pl_conn (AVAILABILITY ZONE 'use1-az6') ), SASL MECHANISMS 'PLAIN', SASL USERNAME 'key', SASL PASSWORD SECRET secret, SECURITY PROTOCOL 'SASL_SSL' ); ``` ## Test plan - [x] Parser tests updated (roundtrip, error cases) - [x] Testdrive updated (connection-create-drop, connection-alter) - [x] `cargo check` passes - [x] Cloudtest validation ([see follow-up PR](#36162)) - [ ] Manual testing against Confluent Cloud PrivateLink ## Docs - [ ] #36163 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Functional changes have been moved to #36161 Docs changes are retained here, but they are now outdated. The SQL syntax for rule-based PrivateLink routing has changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO