Skip to content

Improve test reliability #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sorenisanerd merged 3 commits into from
Jan 29, 2026
Merged

Improve test reliability #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd07766
Cap test runs at 15 minutes
sorenisanerd Jan 28, 2026
3c85f68
Use /dev/disk/by-id names in run_tests.sh
sorenisanerd Jan 28, 2026
98f1c01
Resolve install_target symlink
sorenisanerd Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,11 +119,13 @@ jobs:
# Asciinema lets us record the VM text console.
sudo apt-get install -y ovmf asciinema
- name: Run (only) installer test with nvme block device
timeout-minutes: 15
run: |
#!/bin/bash
./run_tests.sh --blockdev-type nvme --no-self-test

- name: Run full self test with virtio block device
timeout-minutes: 15
run: |
#!/bin/bash
./run_tests.sh
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,11 +88,13 @@ jobs:
# Asciinema lets us record the VM text console.
sudo apt-get install -y ovmf asciinema
- name: Run (only) installer test with nvme block device
timeout-minutes: 15
run: |
#!/bin/bash
./run_tests.sh --blockdev-type nvme --no-self-test

- name: Run full self test with virtio block device
timeout-minutes: 15
run: |
#!/bin/bash
./run_tests.sh
Expand Down
2 changes: 2 additions & 0 deletions mkosi.images/initrd/mkosi.extra/usr/lib/mangos/mangos-install
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,8 @@ partition_device_name() {
esac
}

install_target="$(readlink -f "${install_target}")"

${echo} /usr/lib/systemd/systemd-pull --force --verify=no --roothash=no --verity=no --direct raw "file://${rootimg}" "$(partition_device_name "${install_target}" 5)"

# Extract partition UUID and set partition name from the filename.
Expand Down
6 changes: 3 additions & 3 deletions run_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ then
usage
fi

install_target="/dev/vdb"
install_target=/dev/disk/by-id/virtio-persistent

eval set -- "${args}"
while true
Expand All @@ -101,10 +101,10 @@ do
--blockdev-type)
case "$2" in
virtio-blk-pci)
install_target=/dev/vdb
install_target=/dev/disk/by-id/virtio-persistent
;;
nvme)
install_target=/dev/nvme1n1
install_target=/dev/disk/by-id/nvme-QEMU_NVMe_Ctrl_persistent
;;
*)
echo "Invalid block device type: $2" >&2
Expand Down