Skip to content

Fix and update tests for 3.x#967

Open
circulon wants to merge 10 commits into
MasoniteFramework:3.xfrom
circulon:fix/update_3.x_tests
Open

Fix and update tests for 3.x#967
circulon wants to merge 10 commits into
MasoniteFramework:3.xfrom
circulon:fix/update_3.x_tests

Conversation

@circulon

@circulon circulon commented May 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR is a tests cleanup including:

  • fixing tests that did not have any assertions causing a technical false positive pass
  • enabling some commented out tests
  • moving the grammar query strings into the tests for simplicity and readability.
  • added a precommit and CI check to make sure that each test has at least one assert in it
  • cleanup and tidy
  • moved migrations and seeds into tests folder
  • sqlite db tests now use migrations and seeds for setup, removing the need for a tracked orm.sqlite3 file
  • removed some unused files

circulon added 10 commits May 16, 2026 12:30
@circulon
cleanup
d4a3162 
moved test related modules into test folder (seeds and migrations)
removed unused UserObserver

# Conflicts:
#	orm.sqlite3
#	tests/integrations/migrations/2020_04_17_000000_create_friends_table.py
#	tests/integrations/migrations/2020_04_17_00000_create_articles_table.py
@circulon
fixed migrations path for ci tests
e4dcc27 
# Conflicts:
#	.github/workflows/pythonapp.yml
@circulon
fixed seeds path
6ad9266 
# Conflicts:
#	tests/seeds/test_seeds.py
@circulon
fixed sqlite tests
c238f24 
sqlite tests now use migrations and seeders for standard testing
deleted orm.sqlite3 file

# Conflicts:
#	.gitignore
#	orm.sqlite3
#	tests/integrations/migrations/2018_01_09_043202_create_users_table.py
#	tests/integrations/seeds/user_table_seeder.py
#	tests/sqlite/models/test_sqlite_model.py
@circulon
moved conftest for use with other tests
7aeeeb2
@circulon
fixed timestamps
30fcf83
@circulon
removed unused config
02bc1d1
@circulon
added check that all tests have an assertion
4dafbc1 
This addresses the issue where a test has been partially completed but no “assert” was added.
In this case pytest classes the response as a technical pass

the script will be run during pre-commit checks and as part of the CI test run
@circulon
updated tests
6420fb2 
cleaned up for readability
- moved all grammar test values into the associated test.
- renamed test classes where required
Added assertions to tests that did not have them (causing false positive pass)
Enabled commented out tests
General cleanup and tidy
@circulon
added extra test checks
d1869c3
@eaguad1337 eaguad1337 mentioned this pull request Jun 7, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@circulon