feat(domain): auto delete notifications#400
Conversation
petermasking
changed the title
petermasking
left a comment
petermasking
left a comment
There was a problem hiding this comment.
Almost there! Just a few things. Also, the notification getById feature doesn't include the deleted flag yet.
| { | ||
| const notifications = await getNotifications(postId); | ||
|
|
||
| return notifications.map(item => deleteData(item.id)); |
There was a problem hiding this comment.
| return notifications.map(item => deleteData(item.id)); | |
| const promises = notifications.map(item => deleteData(item.id)); | |
| await Promise.allSettled(promises); |
Return type: Promise<void>
There was a problem hiding this comment.
This file contains the actual feature, and therefore should be named remove.ts.
| @@ -0,0 +1,2 @@ | |||
|
|
|||
| export { default } from './deleteData'; | |||
There was a problem hiding this comment.
| export { default } from './deleteData'; | |
| export { default } from './remove'; |
|
|
||
| export default async function remove(id: string): Promise<void> | ||
| { | ||
| return database.updateRecord(RECORD_TYPE, id, { deleted: true }) as Promise<void>; |
There was a problem hiding this comment.
| return database.updateRecord(RECORD_TYPE, id, { deleted: true }) as Promise<void>; | |
| return database.updateRecord(RECORD_TYPE, id, { deleted: true }); |
|
|
||
| import database from '^/integrations/database'; | ||
|
|
||
| import type { RecordQuery } from '^/integrations/database'; |
There was a problem hiding this comment.
The import should be grouped with the other ^/integration/... import.
|
|
||
| import database from '^/integrations/database'; | ||
|
|
||
| import type { RecordQuery } from '^/integrations/database'; |
There was a problem hiding this comment.
The import should be grouped with the other ^/integration/... import.
There was a problem hiding this comment.
The file tests the remove feature of the notification. The name of the file should reflect this.
|
|
||
| expect(result).toHaveLength(0); | ||
| }); | ||
|
|
There was a problem hiding this comment.
This empty line is not required
|
|
||
| import getByPostId from '^/domain/notification/getByPostId'; | ||
| import removedPost from '^/domain/notification/notify/removedPost'; | ||
| import { DATABASES, VALUES } from './fixtures'; |
There was a problem hiding this comment.
There should be an empty line before this import. Those above are coming from the domain, and this one from ./
|
basmasking
deleted the
342-delete-notification-when-deleting-related-item
branch
johnmasking
restored the
342-delete-notification-when-deleting-related-item
branch
basmasking
deleted the
342-delete-notification-when-deleting-related-item
branch
3 participants
Fixes #342
Changes proposed in this pull request:
@MaskingTechnology/comify