Skip to content

Feature/alpha mask filter#49

Open
InnoLuke wants to merge 4 commits intoMasayukiSuda:masterfrom
Innovattic:feature/alpha-mask-filter
Open

Feature/alpha mask filter#49
InnoLuke wants to merge 4 commits intoMasayukiSuda:masterfrom
Innovattic:feature/alpha-mask-filter

Conversation

@InnoLuke
Copy link
Copy Markdown

@InnoLuke InnoLuke commented Jan 17, 2020

Based on #42

  • Position of alpha mask within the video is a configurable parameter
  • Adds the ability to handle transparency in EPlayerRenderer
  • Adds a hook for GlFilters to modify videoAspect
  • Adds a subclass of EPlayerView - EPlayerTranslucentView. EPlayerTranslucentView allows for video transparency, without breaking EPlayerView
  • Sample is untouched

Migrated from #48 to allow for continued development

@InnoLuke InnoLuke mentioned this pull request Jan 17, 2020
Closed
@InnoLuke InnoLuke requested a review from MasayukiSuda January 30, 2020 13:03
@MasayukiSuda
Copy link
Copy Markdown
Owner

MasayukiSuda commented May 21, 2020

GlFilterGroup is broken. Please fix.

@damikdk
Copy link
Copy Markdown

damikdk commented Dec 27, 2022 •
edited
Loading

Hi, thanks for the amazing fork. Is it possible to finish this?

2022, Android still can't play transparent videos without your code

@jordond jordond mentioned this pull request May 16, 2023
Merged
@mytemizerInno mytemizerInno deleted the feature/alpha-mask-filter branch November 11, 2024 17:10
@mytemizerInno mytemizerInno restored the feature/alpha-mask-filter branch November 11, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MasayukiSuda MasayukiSuda Awaiting requested review from MasayukiSuda

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@InnoLuke @MasayukiSuda @damikdk