Repository navigation
refactor: clean up code duplications - #181
Merged
Merged
Conversation
StackedRNN and FastSlow built their layer/cell lists as untyped
Vector{Any}, grown via push!. Switched both to ntuple(...) do ... end,
matching the pattern already used in RHNCell. Verified gradients still
flow (vector and batched input) and all existing tests pass.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Every AbstractRecurrentLayer{S} subtype wraps a single `cell` field and
needed a hand-written `functor` override, because Functors.jl's structural
default reconstructs via the bare type name and can't recover the phantom
type parameter S from the cell field alone. All 42 were byte-for-byte the
same mechanical shape modulo the type name, so replaced them with one
generic method in generics.jl dispatching on the abstract type.
Verified fmap/Flux.f64 round-trips and Flux.gradient still work across all
42 exported layer types, no dispatch ambiguity, and all existing tests
still pass.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #181 +/- ##
==========================================
+ Coverage 75.29% 82.91% +7.61%
==========================================
Files 40 40
Lines 1789 1621 -168
==========================================
- Hits 1347 1344 -3
+ Misses 442 277 -165 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.