Skip to content

major refactor - #29

Merged
MartinuzziFrancesco merged 8 commits into
masterfrom
fm/claude
Jul 29, 2026
Merged

MartinuzziFrancesco merged 8 commits into
masterfrom
fm/claude

Conversation

@MartinuzziFrancesco

@MartinuzziFrancesco MartinuzziFrancesco commented Jul 17, 2026 •

Copy link
Copy Markdown
Owner

closes #28 #9 #5

MartinuzziFrancesco and others added 8 commits July 17, 2026 11:22
- Fix eltype handling: use eltype instead of typeof(x[2]) and drop
  hardcoded Float64 outputs, so Float32/Dual numbers flow through
- Fix TCA codeset length for radius != 1 ((states-1)*nsize + 1)
- Fix Life for radius != 1 (loop bounds and window size) and make
  life_application non-mutating
- Replace string round-trip ruleset/state decoding with digits() and
  integer arithmetic (also fixes states > 10)
- Handle asymmetric tuple radii uniformly in DCA/CCA/TCA padding
- Make CCA evolution non-mutating and ForwardDiff-differentiable
  (modf -> x - floor(x)); add AD regression test
- Use ConcreteStructs.@concrete for all structs
- Widen JET compat for Julia 1.12; add compat entries; bump to 0.0.7

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01G61PwsNdbkc4nHZW9DhWbQ
Comparison with the fm/codex work (stashed): adopt its stronger design
pieces, keep this branch's kernel implementations.

Adopted:
- Descriptive abstract type names (AbstractCellularAutomatonRule and the
  per-family supertypes) replacing AbstractODRule/AbstractTDRule
- Pure next_state(rule, state; boundary) + rollout(rule, state, steps;
  save) functional core; CellularAutomaton is now a wrapper over rollout
  with no in-place history writes
- Boundary condition types Periodic/Reflecting/ConstantBoundary with
  shared Neighborhood1D access (replaces vcat padding and the Life
  virtual expansion)
- Constructor validation (rule fit, states, radius, generations)
- spatial_dimensions trait, regression tests, boundary/rollout AD tests,
  ad_design.md and docs wiring

Kept over codex: digits()-based ruleset conversion (its string parsing
breaks for states > 10), x - floor(x) for ForwardDiff, closures instead
of callable Update structs. Renamed DCA/CCA kernels to dca_evolution/
cca_evolution to resolve a method ambiguity the shared name caused.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01G61PwsNdbkc4nHZW9DhWbQ
SciML style guide says to avoid closures even when a particular closure
would not be problematic (accidental type instabilities), so the rollout
transition and the per-rule kernels now use @concrete callable structs
(Transition, DCAUpdate, CCAUpdate, TCAUpdate, LifeUpdate) as in the
codex draft.

Convert all docstring examples to jldoctest blocks (verified with
Documenter.doctest; docs CI already runs makedocs with doctest=true).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01G61PwsNdbkc4nHZW9DhWbQ
- CI: bump checkout@v4 and setup-julia@v2, test on lts + latest
- README: fix broken docs badge URL (pointed at SpectralIndices.jl),
  switch style badge Blue -> SciML, https for wolfram/golly links
- Switch .JuliaFormatter.toml to style = "sciml" and reformat
- Rename CellularAutomaton field generation_fun -> rule
- lempel_ziv: clear ArgumentError for 2D automata instead of a
  confusing BoundsError on the 3D evolution array
- Fix "Two Dimensial" typo in docs pages
- Bump version to 0.1.0 to signal the API overhaul

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01G61PwsNdbkc4nHZW9DhWbQ
Rules and ConstantBoundary print in reconstructable constructor form
(e.g. DCA(30; states=2, radius=1)). CellularAutomaton gets a compact
inline form and a three-line text/plain summary showing the rule and
evolution size instead of the raw parameter spew.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01G61PwsNdbkc4nHZW9DhWbQ
- Gate JET.test_package to Julia >= 1.12: JET 0.9 (the only release
  installable on older Julia) reports a false positive inside Base's
  digits! BigInt path when analyzing digits_ruleset abstractly
- Set GKSwstype=100 for the docs build so the Plots @example pages
  render on the headless runner
- Run the format check on x64 instead of x86, where the resolver can
  pick a different JuliaFormatter
- Upgrade remaining http links in docs pages to https (linkcheck 301s)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01G61PwsNdbkc4nHZW9DhWbQ
SourceForge returns 403 to GitHub Actions runners, failing the docs
build; keep the link for readers but skip checking it.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01G61PwsNdbkc4nHZW9DhWbQ
…formatting

Prefix internal helpers/structs with `__` per SciML convention, replace
direct field access (ca.evolution, dca.ruleset, ...) with accessor
functions (evolution_history, rule_lookup_table, ...), and validate
discrete rule states in next_state. Switch CI formatting from
JuliaFormatter/SciMLStyle to Runic and reformat the tree. Fix docs
examples that fed Float64 zeros into discrete rules, now rejected by
the new state validation.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016ytx2Zi8as1AFPNenre9ZB
@MartinuzziFrancesco
MartinuzziFrancesco merged commit 0c96a25 into master Jul 29, 2026
15 of 16 checks passed
@MartinuzziFrancesco
MartinuzziFrancesco deleted the fm/claude branch July 29, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Abstract boundary conditions

1 participant