Bump minimum CMake version to 3.5#235
Merged
Martinsos merged 2 commits intoMartinsos:masterfrom May 11, 2025
Merged
Conversation
Contributor
|
(Bump for this; I'm needing this as well in my fork that's used in edlib-rs.) |
Owner
|
Thanks for the PR! Sounds like it makes sense to merge this, but couple of quick questions first:
|
Martinsos
reviewed
May 11, 2025
With the recent release of CMake 4.0, support for versions less than 3.5 have been removed.
Owner
|
All right, I actually went for 3.20 -> from what I see, 3.20 is about 4y old, I think that is more than enough, and also it gives us some leeway before having to update the version to a newer one again. Thanks for this PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the recent release of CMake 4.0, support for versions less than 3.5 have been removed.
This is a minimal bump to get things building again, though note that CMake now warns about a future deprecation: