Guard demo.sh against removed results/ artifacts - #35
Merged
Merged
Conversation
demo.sh runs under 'set -euo pipefail' and read five committed results/ files that were removed in #34 — the first missing file aborted the whole demo. Each artifact section is now wrapped in a have() check that prints a skip line and continues; the closing Sources list no longer advertises files that are not tracked. The Day-2 determinism section is untouched — it runs pytest, not an artifact read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts/demo.shruns underset -euo pipefailand read fiveresults/*files removed in #34. The first missing file aborted the entire demo.Fix
A
have()helper guards each of the five artifact sections:results/baseline_metrics.jsonresults/registry_rollback_times.csvresults/drift_replay_summary.jsonresults/drift_retrain_events.csvresults/day06/frontier_comparison.csvA missing artifact prints a skip line and the demo continues. The closing Sources list no longer advertises untracked files.
The Day-2 Pandas-vs-Dask section is untouched — it runs
pytest tests/test_features_determinism.py, a real test, not an artifact read.Verification
bash -npasses, and the guard was exercised underset -euo pipefailwith the artifact absent: it prints the skip line and reaches the end of the script with exit code 0, instead of aborting at the first read.