Skip to content

sprint: fix Day-7 CI — relax yanked protobuf pin (==5.24.1 -> >=4.25,<6) - #29

Merged
Mark007-R merged 1 commit into
devfrom
sprint/day07-ci-protobuf-fix
May 24, 2026
Merged

Mark007-R merged 1 commit into
devfrom
sprint/day07-ci-protobuf-fix

Conversation

@Mark007-R

Copy link
Copy Markdown
Owner

What

The Day-7 CI workflow (added in #28) failed on its very first run during `pip install -r requirements.txt`:

```
ERROR: Could not find a version that satisfies the requirement protobuf==5.24.1
(from versions: ..., 5.23.4, 5.26.0, 5.26.1, ...)
ERROR: No matching distribution found for protobuf==5.24.1
```

PyPI yanked the 5.24.x and 5.25.x protobuf releases — available versions now jump from 5.23.4 straight to 5.26.0. The exact pin became unreachable.

Why this only surfaced today

There was no CI before #28. Local dev environments already had `protobuf==5.24.1` installed, so `pip install -r requirements.txt` was a no-op there. The fresh GitHub Actions runner is the first clean install since the upstream yank, which is why CI is the messenger for a pre-existing pin issue.

Fix

Replace the exact pin with a range:

```
protobuf>=4.25,<6
```

`pip --dry-run` on this branch resolves to `protobuf-4.25.9`, which is what streamlit 1.28.1's own pin window (`>=3.20,<5`) allows. No other pin in requirements.txt is affected.

Verification

  • Local `pip install --dry-run -r requirements.txt` resolves cleanly to `protobuf-4.25.9`.
  • All 31 unit tests still pass on the host with the pre-existing `protobuf 5.24.1` install (no behavioural change).
  • Once merged, CI on `dev` should turn green on the next push.

Files touched

  • `requirements.txt` — single-line pin change + a 5-line comment explaining the yank.

…,<6 (Day 7 CI fix) — fresh installs were failing on 'No matching distribution found for protobuf==5.24.1'; resolver now picks 4.25.9 which streamlit 1.28.1 accepts
Copilot AI review requested due to automatic review settings May 24, 2026 07:50

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Mark007-R
Mark007-R merged commit 40ef4f5 into dev May 24, 2026
1 check failed
@Mark007-R
Mark007-R deleted the sprint/day07-ci-protobuf-fix branch May 24, 2026 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants