Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test script is scripts/nisha/avg_data_source.py. It ...
Possible issue, but not sure if it is an issue/how to fix it: The time range for the monthly data source is the whole month, so there is an overlap of time ranges inside the dataframe. For example, for the range 11/24 - 12/1, there is forecast time steps for 11/24 to 11/27 and then the monthly forecast has its time range as 11/16 - 12/16 to fill in the rest of the time.
config/arena/gulf_of_mexico_LongTermAverageSource.yaml is an example of how my code expects the config to look. There should be two setting dictionaries inside the forecast field - one for forecast and one for the average.