feat: harden cache mount lifecycle with guard pins - #68
Merged
Conversation
This reverts commit 6a51e9e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PreparedCacheEntryclone cleanup and its entry lock final-drop owned;guard execpins for exact completed managed-cache sources, held through child cleanup and guard-session release;This hardens the lifecycle behind the historical fail-closed Docker exit 125 without attributing the disappearing bind source to an unproven actor.
Trust claim checklist
noneonly after checking the diff.Impact and rollback
Evidence checklist
cargo fmt --all -- --checkwhen Rust files changed.git diff --checkpasses.CHANGELOG.md— not included in the authorized exact-head branch; this remains an explicit review item.Validation notes
rtk cargo test --test cache_pin_contract: PASS, 1 test.rtk cargo test --lib completed_source_pin: PASS, 12 tests.rtk cargo test --lib cache::tests: PASS, 30 tests.rtk cargo test --bin commit-ci-preflight: PASS, 22 tests.rtk cargo test --lib: PASS, 244 tests, 1 ignored.rtk cargo test --all-targets --all-features: PASS, 362 tests, 3 ignored.rtk cargo test --doc: PASS, 0 doctests discovered.rtk cargo check --all-targets: PASS.rtk cargo fmt --all -- --check: PASS.rtk git diff --check: PASS.rtk cargo clippy --all-targets --all-features -- -D warnings: NOT-RUN becausecargo-clippyis not applicable to the installed1.96.0-aarch64-apple-darwintoolchain.Exact branch head:
693f93cc50272f1381419ebdb1150c9a08a4a50f.