Add physical Firewall/NAT write lifecycles - #33
Merged
Merged
Conversation
MarcLeinenDE
marked this pull request as ready for review
September 25, 2026 05:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare persistent public-SDK physical coverage for the 13 Firewall/NAT write methods identified by the canonical API↔SDK audit.
Upstream first:
This branch adds two opt-in physical suites:
No physical result is claimed yet. Keep this PR open until both tests have run against the dedicated router and any new protocol observations have first been normalized in nr2301-api.
Physical run 1 (2026-09-21):
The failed assertion occurred inside a try/finally lifecycle, so the restore path executed. A full rerun is still required to prove final exact semantic restoration and continue through Port Trigger, URL Filter and UPnP.
Physical run 2 (2026-09-21):
Physical run 3 (2026-09-21):
Physical run 4 / reversible lifecycle closure (2026-09-25):
FIREWALL_FINAL dmz_restored=True vpn_restored=True wan_controls_restored=True filters_restored=True nat_rules_restored=True upnp_restored=True
PASSED
Remaining campaign scope after this PR:
firewall/fw_edit_dmz_entrystill lacks a clean exact-restore physical closure from the original sentinel statePhysical run 5 / DMZ destination sentinel finding (2026-09-25):
192.168.192.168.through the setter did not restore getter stateCurrent physical disposition: