Skip to content

feat(transcriber): refine subtitle splitting/merging and resolve codex bugs - #21

Merged
Mapleeeeeeeeeee merged 4 commits into
mainfrom
feat/refined-subtitle-splitting
Jul 9, 2026
Merged

feat(transcriber): refine subtitle splitting/merging and resolve codex bugs#21
Mapleeeeeeeeeee merged 4 commits into
mainfrom
feat/refined-subtitle-splitting

Conversation

@Mapleeeeeeeeeee

Copy link
Copy Markdown
Owner

Summary

  • Added comprehensive unit tests for short subtitle clause merging.
  • Fixed three bugs identified by Codex (enforcing duration limits on force-splits, extending CJK range/punctuation detection to Japanese/Korean/全形符號, and correcting index-based final timing alignment).

Changes

  • transcriber.py
  • test_transcriber.py

Test Plan

  • Run unit tests: uv run pytest tests/unit -m unit (all 230 tests pass).

@Mapleeeeeeeeeee
Mapleeeeeeeeeee merged commit 5e5cb74 into main Jul 9, 2026
7 of 8 checks passed
@Mapleeeeeeeeeee
Mapleeeeeeeeeee deleted the feat/refined-subtitle-splitting branch July 9, 2026 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant