fix: improve foreign stock chart readability#445
Open
AlexTzib wants to merge 1 commit into
Open
Conversation
c9cf02b to
653ecfd
Compare
653ecfd to
f4d7ac7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small follow-up to make the foreign stock history graph easier to read without changing the rest of the foreign stock flow.
What this changes:
Why:
The old graph could be a bit misleading because a 3 minute gap and a 30 minute gap were drawn the same way. That made the history harder to reason about, especially around restocks. This keeps the existing chart and data, but presents the time axis closer to what actually happened.
Local verification:
I could not run Flutter analyzer/build locally because flutter/dart are not available on this PATH, so I expect GitHub CI to be the real compile check here.