ci: add experimental verification checks#444
Conversation
|
@Manuito83 small note from the experimental run: this is not directly related to this PR, but the new checks surfaced a few existing repo-maintenance topics that are probably worth discussing separately.
|
|
What this CI experiment is meant to achieve:
The goal is not to make CI stricter for the sake of it. The goal is to catch common review-time misses automatically, while keeping the checks scoped enough that normal app PRs stay practical. |
|
Thanks. A few thoughts:
|
DRAFT - do not merge yet
This PR is intentionally opened as a draft to test extra CI checkers before we decide whether they are stable enough to keep or require.
Summary
Adds three independent verification jobs:
Dart Format: checks formatting only for changed Dart files underlib/andtest/Generated Code Drift: runs only when generator inputs changed, then runsdart run build_runner build --delete-conflicting-outputsand fails ifgit diff --exit-codefinds generated changesDependency Review: runsactions/dependency-review-action@v4on PRs and fails on newly introduced high/critical vulnerable dependenciesWhy
The existing CI already checks analyze, tests, Cloud Functions, Android build, and iOS build. These extra jobs are meant to catch different classes of mistakes:
What the first draft run showed
The first version checked all Dart files and all generated outputs. That was too broad for the current repo baseline:
Dart Formattried to reformat 377 existing filesGenerated Code Driftfound existing swagger/env generated output driftThis PR was tuned so unrelated PRs are not blocked by existing baseline debt:
Things to evaluate before merge
fail-on-severity: highVerification
git diff --checkpassed locally