Skip to content

Issue 198 - Fix an issue with settings in AniList provider#226

Open
hmsmart wants to merge 1 commit into
MangaManagerORG:mainfrom
hmsmart:hmsmart/issue-198
Open

Issue 198 - Fix an issue with settings in AniList provider#226
hmsmart wants to merge 1 commit into
MangaManagerORG:mainfrom
hmsmart:hmsmart/issue-198

Conversation

@hmsmart
Copy link
Copy Markdown

@hmsmart hmsmart commented Apr 22, 2025

Pull Request to address #198.
Initial Issues Appeared to be as follows:
MangaManager/ExternalSources/MetadataSources/Providers/AniList.py on line 38:

romaji_as_series = True

This value should be dynamic and whatever settings are loaded from ini.

romaji_as_series = Settings().get(name, AniListSetting.SeriesTitleLanguage)

Additionally, I've updated the save_settings method to be a class method, since all instances should share the same settings anyway. Without doing this, settings changes in the GUI are not represented until restart when the factory remakes the AniList provider.

Finally, a change is made to properly complete all states for the setting:

true: Romaji->Series, English->LocalizedSeries
false: English->Series, Romaji->LocalizedSeries
Always Romaji->Series when no English

MangaManager/ExternalSources/MetadataSources/Providers/AniList.py on line 141:

comicinfo.series = title_english if title_english != "" else title_romaji. 

@hmsmart hmsmart changed the base branch from main to develop April 22, 2025 11:39
@hmsmart hmsmart changed the base branch from develop to main April 22, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant