Issue 198 - Fix an issue with settings in AniList provider#226
Open
hmsmart wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request to address #198.
Initial Issues Appeared to be as follows:
MangaManager/ExternalSources/MetadataSources/Providers/AniList.py on line 38:
This value should be dynamic and whatever settings are loaded from ini.
Additionally, I've updated the save_settings method to be a class method, since all instances should share the same settings anyway. Without doing this, settings changes in the GUI are not represented until restart when the factory remakes the AniList provider.
Finally, a change is made to properly complete all states for the setting:
MangaManager/ExternalSources/MetadataSources/Providers/AniList.py on line 141: