Fix issue #222#223
Open
SilverTorus wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves issue: #222
Changes Made
Fix a bug where ComicInfo.xml could not be found when not at the archive root. Changed the list comprehension to return the first occurrence of a filepath within the archive that ends with "ComicInfo.xml".
Original Technical Issue
ComicInfo.xml could not be found when not at the archive root. This occurred because the index 0 of the list comprehension in the class LoadedFileMetadata would always return false and the fallback path within the archive (ComicInfo.xml) would be chosen instead.
This occurred because the list comprehension was returning a list of boolean values generated by comparing filename.endswith("ComicInfo.xml"). Since index 0 of an archive.namelist() will always return a folder or file at the root (and not a ComicInfo.xml since it's not at the root) , the value will always be false.