Fix/series part roundtrip - #18
Merged
Merged
Conversation
…stream myxdvz#27) The log writes seriesparts as "Name part" and the reader split on "#", so a fix.csv row came back with the series named "Pike Logan 17.5" and no part. The reader now pairs seriesparts with the series column, cleansing both the same way, and reads a pre-fix "17 5" back as 17.5. The writer keeps the part verbatim (17.5, not "17 5"). Corpus replay: four novellas' match-rate strings change by the dot, no match changes. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
The run log writes
seriespartsasPike Logan 17.5but the log-mode reader (fix.csv, the books-mcp apply unit) split on#, so theseries came back named
Pike Logan 17.5with no part. The writer also ran the part through the author cleanser, so17.5was logged as17 5— the "decimal parts don't come through" half of upstream myxdvz#27.Fix
Book.setSeriesFromLog): pairsseriespartswith theseriescolumn, cleansing both the same way; reads a pre-fix17 5back as
17.5; hand-writtenName #partrows still work.getSeriesParts): the part is kept verbatim (17.5); the name is cleansed exactly as before.docs/FORK.mditem 6 marked closed (with target_path/in_series_no_part: a series entry without a part no longe… #17).Validation
tests/test_logmode.py(round trip incl. a series ending in a number, old17 5rows, names the two columns cleansedifferently,
#form). 201 tests OK, ruff clean.Jack Reacher 23 5→23.5); no match, cachekey or target path changes.