Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
locales/zh-CN.jsonwith the full catalogue translated (1307 entries), registers it insrc/i18n/registry.ts, and adds a简体中文section tolocales/CREDITS.md— followinglocales/README.mdexactly: keys untouched,{placeholders}untouched, plural categories kept,one line in the registry.
Checks run
The 3 failures (
cjkTypography,sketch/textDrag,sketch/trimRawCursor) also fail on theunmodified tree on this machine, so they are not caused by this change.
One thing worth your attention (pre-existing, not touched here)
Several tests assert English label text. On a machine whose Node/ICU default locale is
zh-CN,detectLocale()now resolves tozh-CNand 101 further tests fail purely because the stringsthey assert are translated. On an English-locale runner (CI) they all pass. So the suite is
locale-sensitive today; pinning the locale in a test setup file would fix that, but it is your call
and this PR deliberately does not touch tests.
Notes
"zh-CN"is registered so an exactnavigator.languageofzh-CNis auto-detected. A barezhstill falls back to English (the picker offers 简体中文).
D,R,B / I,TinkerAtlas,{a} ∩ {b}, …) where translating would be wrong.locales/and the one registry line is touched.