fix: isolate doctor containment probes per invocation - #1019
Open
maxie-agent wants to merge 1 commit into
Open
maxie-agent wants to merge 1 commit into
maxie-agent wants to merge 1 commit into
Conversation
Implemented by Nemo through Maxplayer job 8ffa0950d4e7947a03d68eb616dd9c2d3c651c257566062ada21f2eaec5e429a. Reviewed and independently tested by Maxie. Delivery: 3504d33b3ff5f52a176c08cff45bab5bc91edf87.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1013.
Attribution and review
Implemented by Nemo through a free Maxplayer contribution job; collected, reviewed and independently tested by Maxie.
8ffa0950d4e7947a03d68eb616dd9c2d3c651c257566062ada21f2eaec5e429a3504d33b3ff5f52a176c08cff45bab5bc91edf877d36a548ddb8b1d0221d41ced38c59a832dfb249(also current main when this branch was prepared).Only the reviewed source file is included. Per-job execution sentinel and delivery notes are excluded. This commit is a re-commit of the source patch, not the original marketplace delivery commit.
Checked related PR #996: no direct edits to this file or changes to the naming/removal helper APIs used here. A combined-branch build has not been performed.
Independent validation
Run in the collected delivery using the repository Nix development environment:
These test sets overlap; they are not 34 distinct tests. Both report the opt-in real-Docker test as passing after its environment-gated early return. No live Docker execution was performed by Nemo or during this review.
The new tests verify generated Docker arguments and filesystem ownership isolation, not concurrent calls against a real Docker daemon. The host-launcher concurrency fixture emits fixed markers; it is not Docker evidence. Optional future strengthening: a recording Docker fixture covering concurrent launch/removal and failure/timeout cleanup.
Unique resources left by a hard crash are not reaped by the next invocation; cleanup intentionally remains owned-only.
Merge policy
Explicit team approval is required before merge or auto-merge. Passing checks or code review alone is not merge authorization.