docs(release): correct two v0.5.9 release-note sentences - #1008
Merged
jbojcic1 merged 1 commit intoSep 17, 2026
Merged
Conversation
The docker alias sentence named only the MCP-server trigger. The predicate at crates/maxplayer-core/src/seller_exec.rs:1137-1145 adds --add-host only when the job carries no netns AND either an env value or an MCP server entry references PROXY_HOST_ALIAS, so an environment reference alone is sufficient and the alias is never added under namespace containment. The evidence sentence claimed every bundle under evidence/ carries a README. Three of the six do: the 20260914T* bundles of this feature. Scoped the claim to them.
|
Someone is attempting to deploy a commit to the MakePrisms Team on Vercel. A member of the Team first needs to authorize it. |
jbojcic1
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two statements merged into
mainwith #1007 do not match the tree. This corrects both, inRELEASE_NOTES.mdonly — no other file, no code.1. The docker alias sentence. It read "The docker alias pinhole opens only when an MCP server entry names it." The predicate at
crates/maxplayer-core/src/seller_exec.rs:1137-1145isjob.netns.is_none() && (env value contains PROXY_HOST_ALIAS || mcp_servers references PROXY_HOST_ALIAS), so an environment reference alone is sufficient, and the alias is never added under namespace containment. New text: "The docker alias pinhole opens only for a job outside namespace containment, and only when that job's environment or one of its MCP server entries references the alias."No enforcement defect is alleged or implied: the comment above that predicate records that the daemon refuses
--add-hosttogether with the namespace network mode outright (rc 125), so the omission there is not a gap.2. The evidence-README sentence. It read "each bundle under
evidence/carries a README stating what it proves and its limits." Counted in this tree:evidence/holds six bundles; three carry aREADME.md(20260914T085619Z-github-proxy-swap,20260914T095551Z-holder-route,20260914T103608Z-holder-route-two-tools, each with a## Limitssection) and the three older20260909T…/20260910T…bundles do not. The claim is now scoped to this feature's three bundles.Verified first-hand in this worktree: the predicate read at source, the bundle/README count run against
evidence/, and the diff read back after writing. Branch cut fresh offMakePrisms/mainat7d36a548.